Bump old hls version and upgrade test runner to macos-latest #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
approved these changes
Sep 20, 2023
fendor
reviewed
Sep 20, 2023
| ghcup set ghc ${{matrix.ghc}} | ||
| ghcup install hls 1.4.0 | ||
| ghcup install hls 2.2.0.0 |
There was a problem hiding this comment.
Actually, this is wrong because the test is supposed to test our ability to fallback to older HLS versions for unsupported GHC versions.
There was a problem hiding this comment.
But since the next release drops support for 8.10.7, this will be correct again :)
There was a problem hiding this comment.
Yes, thinking that we may not merge big changes before the next hls release, it's not bad to write it here now.
fendor
pushed a commit
to fendor/vscode-haskell
that referenced
this pull request
Dec 2, 2023
…#960) * Bump to ghc-8.10.7 * Use macos latest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://haskell-language-server.readthedocs.io/en/latest/support/ghc-version-support.html, HLS has dropped ghc-8.10.7 after hls-2.2.0.0, so we can replace 8.10.4 with 8.10.7 and hope it can make our test more stable...